linux-kernel - Re: [PATCH net-next] net: bridge: remove unneeded variable 'err'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ea956e2-ea17-2fb4-30c4-194e438514a6@cumulusnetworks.com>
Date:   Mon, 17 Dec 2018 13:21:08 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     YueHaibing <yuehaibing@...wei.com>, davem@...emloft.net,
        roopa@...ulusnetworks.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next] net: bridge: remove unneeded variable 'err'

On 17/12/2018 13:16, YueHaibing wrote:
> On 2018/12/17 17:51, Nikolay Aleksandrov wrote:
>> On 17/12/2018 11:46, YueHaibing wrote:
>>> function br_multicast_toggle now always return 0,
>>> so the variable 'err' is unneeded.
>>> Also cleanup dead branch in br_changelink.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>>> ---
>>>  net/bridge/br_multicast.c | 3 +--
>>>  net/bridge/br_netlink.c   | 4 +---
>>>  2 files changed, 2 insertions(+), 5 deletions(-)
>>>
>>
>> That is correct, but in such case just make it void.
> 
> In net/bridge/br_sysfs_br.c:
> 
> static ssize_t multicast_snooping_store(struct device *d,
>                                         struct device_attribute *attr,
>                                         const char *buf, size_t len)
> {
>         return store_bridge_parm(d, buf, len, br_multicast_toggle);
> }
> 
> and store_bridge_parm need the returned err.
> 

That can be worked-around with a set option that returns 0 but it's not that
important.

Fair enough,
Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>