linux-kernel - Re: [PATCH] powerpc/ptrace: cleanup do_syscall_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Dec 2018 14:23:50 +0300
From:   "Dmitry V. Levin" <ldv@...linux.org>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     Oleg Nesterov <oleg@...hat.com>, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/ptrace: cleanup do_syscall_trace_enter

Hi,

On Mon, Dec 17, 2018 at 10:20:26PM +1100, Michael Ellerman wrote:
> "Dmitry V. Levin" <ldv@...linux.org> writes:
> > Invoke tracehook_report_syscall_entry once.
> 
> Thanks.
> 
> > Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
> > ---
> >  arch/powerpc/kernel/ptrace.c | 54 +++++++++++++++++++++---------------
> >  1 file changed, 31 insertions(+), 23 deletions(-)
> >
> > diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
> > index 714c3480c52d..8794d32c2d9e 100644
> > --- a/arch/powerpc/kernel/ptrace.c
> > +++ b/arch/powerpc/kernel/ptrace.c
> > @@ -3263,32 +3263,40 @@ static inline int do_seccomp(struct pt_regs *regs) { return 0; }
> >   */
> >  long do_syscall_trace_enter(struct pt_regs *regs)
> >  {
> > +	u32 cached_flags;
> > +
> 
> Do you mind if I just call it "flags", I find "cached_flags" a bit
> unwieldy for some reason.
> 
> I'm happy to fix it up when applying.

No problem, feel free to call it whatever you like.  Thanks,


-- 
ldv

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)