linux-kernel - Re: [PATCH v2 08/19] mailbox: imx: Use device-managed registration API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181217153108.ycu7xg25edzccv7g@pengutronix.de>
Date:   Mon, 17 Dec 2018 16:31:08 +0100
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     Jassi Brar <jassisinghbrar@...il.com>,
        linux-kernel@...r.kernel.org, Dong Aisheng <aisheng.dong@....com>,
        Vladimir Zapolskiy <vz@...ia.com>
Subject: Re: [PATCH v2 08/19] mailbox: imx: Use device-managed registration
 API

On Mon, Dec 17, 2018 at 04:02:06PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
> 
> Get rid of some boilerplate driver removal code by using the newly added
> device-managed registration API.
> 
> Cc: Oleksij Rempel <o.rempel@...gutronix.de>
> Cc: Dong Aisheng <aisheng.dong@....com>
> Cc: Vladimir Zapolskiy <vz@...ia.com>
> Signed-off-by: Thierry Reding <treding@...dia.com>

Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>

> ---
>  drivers/mailbox/imx-mailbox.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index 363d35d5e49d..774362a05159 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -324,14 +324,13 @@ static int imx_mu_probe(struct platform_device *pdev)
>  
>  	imx_mu_init_generic(priv);
>  
> -	return mbox_controller_register(&priv->mbox);
> +	return devm_mbox_controller_register(dev, &priv->mbox);
>  }
>  
>  static int imx_mu_remove(struct platform_device *pdev)
>  {
>  	struct imx_mu_priv *priv = platform_get_drvdata(pdev);
>  
> -	mbox_controller_unregister(&priv->mbox);
>  	clk_disable_unprepare(priv->clk);
>  
>  	return 0;
> -- 
> 2.19.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)