linux-kernel - Re: [PATCH] serial: uartps: Add the device_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <333f4be8-a4ae-4276-e2ac-725d1ae4c9b0@xilinx.com>
Date:   Mon, 17 Dec 2018 16:29:56 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michal Simek <michal.simek@...inx.com>
CC:     <linux-kernel@...r.kernel.org>, <monstr@...str.eu>,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
        Jiri Slaby <jslaby@...e.com>, <linux-serial@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] serial: uartps: Add the device_init_wakeup

On 17. 12. 18 16:15, Greg Kroah-Hartman wrote:
> On Wed, Dec 05, 2018 at 02:20:11PM +0100, Michal Simek wrote:
>> From: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
>>
>> Initialise the device wakeup.
> 
> Why?  This says what happened, which you can see from the patch itself,
> but it does not say why this is needed at all.

We will fix this.

> 
> Also, you sent 4 patches, without any numbering, so I have no idea what
> order to apply them in.
>
> Please fix the changelog entries up and send this as a patch series so
> that I can correctly apply them.

They are all independent that's why I have sent them separately as
single patches.

Thanks,
Michal