linux-kernel - Re: [PATCH] kbuild: error for CONFIG_ORC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181217170305.chni6e5vmev7hp4r@treble>
Date:   Mon, 17 Dec 2018 11:03:05 -0600
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Qian Cai <cai@....pw>
Cc:     yamada.masahiro@...ionext.com, michal.lkml@...kovi.net,
        mingo@...nel.org, bp@...en8.de, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: Re: [PATCH] kbuild: error for CONFIG_ORC_UNWINDER is too much

On Mon, Dec 17, 2018 at 11:17:28AM -0500, Qian Cai wrote:
> Since ifdef will be evaluated immediately in the first phrase of the
> Makefile read-in, there is no guarantee that the value for
> CONFIG_ORC_UNWINDER will be up-to-date until in the second phrase that
> this recipe is ran.
> 
> include/config/%.conf: $(KCONFIG_CONFIG) include/config/auto.conf.cmd
> 	$(Q)$(MAKE) -f $(srctree)/Makefile syncconfig
> 
> Hence, change error to warning as this is essentially a best guess. The
> original bug can be reproduced this way,

But this still doesn't fix the root of the problem, that the check
relies on a stale auto.conf.

-- 
Josh