linux-kernel - Re: [PATCH] kbuild: error for CONFIG_ORC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1545066839.18411.17.camel@lca.pw>
Date:   Mon, 17 Dec 2018 12:13:59 -0500
From:   Qian Cai <cai@....pw>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     yamada.masahiro@...ionext.com, michal.lkml@...kovi.net,
        mingo@...nel.org, bp@...en8.de, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: Re: [PATCH] kbuild: error for CONFIG_ORC_UNWINDER is too much

On Mon, 2018-12-17 at 11:03 -0600, Josh Poimboeuf wrote:
> On Mon, Dec 17, 2018 at 11:17:28AM -0500, Qian Cai wrote:
> > Since ifdef will be evaluated immediately in the first phrase of the
> > Makefile read-in, there is no guarantee that the value for
> > CONFIG_ORC_UNWINDER will be up-to-date until in the second phrase that
> > this recipe is ran.
> > 
> > include/config/%.conf: $(KCONFIG_CONFIG) include/config/auto.conf.cmd
> > 	$(Q)$(MAKE) -f $(srctree)/Makefile syncconfig
> > 
> > Hence, change error to warning as this is essentially a best guess. The
> > original bug can be reproduced this way,
> 
> But this still doesn't fix the root of the problem, that the check
> relies on a stale auto.conf.
> 

Yes, but it at least let people to be able to continue compiling kernel without
prematurely being terminated incorrectly. The good thing is that that check will
be triggered again to print out the right message once auto.conf has been synced
up.

# make
Makefile:966: "Cannot generate ORC metadata for CONFIG_UNWINDER_ORC=y, please
install libelf-dev, libelf-devel or elfutils-libelf-devel"
  HOSTCC  scripts/kconfig/conf.o
  HOSTLD  scripts/kconfig/conf
scripts/kconfig/conf  --syncconfig Kconfig
Makefile:968: "Cannot use CONFIG_STACK_VALIDATION=y, please install libelf-dev,
libelf-devel or elfutils-libelf-devel"