linux-kernel - Re: [PATCH v1 1/1] MAINTAINERS: update list of qcom drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Dec 2018 10:21:42 +0100
From:   Marc Gonzalez <marc.w.gonzalez@...e.fr>
To:     Kalle Valo <kvalo@...rom.com>,
        Amit Kucheria <amit.kucheria@...aro.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        Andy Gross <andy.gross@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v1 1/1] MAINTAINERS: update list of qcom drivers

On 18/12/2018 08:42, Kalle Valo wrote:

> Amit Kucheria wrote:
> 
>> Several drivers didn't have a specific maintainer (other than the
>> subsystem maintainer). Switch to using the 'qcom' and 'msm' regex
>> patterns to capture all of them and add exceptions to the couple of
>> drivers that contain 'msm' but are not related to qcom hardware.
>>
>> Thanks to Marc for the idea to use the N regex.
>>
>> Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org>
>> ---
>>  MAINTAINERS | 14 ++++----------
>>  1 file changed, 4 insertions(+), 10 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 3318f30903b2..c9376030f77a 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1929,20 +1929,14 @@ M:	Andy Gross <andy.gross@...aro.org>
>>  M:	David Brown <david.brown@...aro.org>
>>  L:	linux-arm-msm@...r.kernel.org
>>  S:	Maintained
>> -F:	Documentation/devicetree/bindings/soc/qcom/
>> -F:	arch/arm/boot/dts/qcom-*.dts
>> -F:	arch/arm/boot/dts/qcom-*.dtsi
>> -F:	arch/arm/mach-qcom/
>> -F:	arch/arm64/boot/dts/qcom/*
>> +N:	qcom
>> +N:	msm
> 
> IMHO this is pretty fragile in the long term. For example only due to
> historical reasons qualcomm wireless drivers currently under ath
> directory but who knows if at some point we switch using qcom (or
> qualcomm) directory.

I am failing to follow your logic.

(IIUC, you are talking about drivers/net/wireless/ath/ath10k)

The fact that the "qcom" or "msm" nomenclature is not used for this driver now
just means that an explicit F entry is required. The fact that it could be renamed
in the future just means that the entry would need to be updated or folded into a
more generic matching pattern. What am I missing?

> Also the wireless drivers might easily have filenames containing
> strings like "msm" or "qcom" (which I assume would match with "N"
> rules above).
Any driver (not just wireless) might match "msm" or "qcom". These could be excluded
with an X directive (as the proposed patch does, in fact).

Regards.