linux-kernel - Re: [PATCH v1 1/1] MAINTAINERS: update list of qcom drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP245DXP4FiQSSKCqdGVOL+Fz=w0rAqvUcsBaL_j9AfCfp7TQg@mail.gmail.com>
Date:   Tue, 18 Dec 2018 15:31:02 +0530
From:   Amit Kucheria <amit.kucheria@...aro.org>
To:     kvalo@...rom.com
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Andy Gross <andy.gross@...aro.org>, marc.w.gonzalez@...e.fr,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v1 1/1] MAINTAINERS: update list of qcom drivers

On Tue, Dec 18, 2018 at 1:12 PM Kalle Valo <kvalo@...rom.com> wrote:
>
> Amit Kucheria <amit.kucheria@...aro.org> writes:
>
> > Several drivers didn't have a specific maintainer (other than the
> > subsystem maintainer). Switch to using the 'qcom' and 'msm' regex
> > patterns to capture all of them and add exceptions to the couple of
> > drivers that contain 'msm' but are not related to qcom hardware.
> >
> > Thanks to Marc for the idea to use the N regex.
> >
> > Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org>
> > ---
> >  MAINTAINERS | 14 ++++----------
> >  1 file changed, 4 insertions(+), 10 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 3318f30903b2..c9376030f77a 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1929,20 +1929,14 @@ M:    Andy Gross <andy.gross@...aro.org>
> >  M:   David Brown <david.brown@...aro.org>
> >  L:   linux-arm-msm@...r.kernel.org
> >  S:   Maintained
> > -F:   Documentation/devicetree/bindings/soc/qcom/
> > -F:   arch/arm/boot/dts/qcom-*.dts
> > -F:   arch/arm/boot/dts/qcom-*.dtsi
> > -F:   arch/arm/mach-qcom/
> > -F:   arch/arm64/boot/dts/qcom/*
> > +N:   qcom
> > +N:   msm
>
> IMHO this is pretty fragile in the long term. For example only due to
> historical reasons qualcomm wireless drivers currently under ath
> directory but who knows if at some point we switch using qcom (or
> qualcomm) directory. Also the wireless drivers might easily have
> filenames containing strings like "msm" or "qcom" (which I assume would
> match with "N" rules above).

I've now sent a v2 of the patch that tries to list all the drivers
explicitly. Let's see which one is better liked. :)

Regards,
Amit