linux-kernel - Re: [PATCH -next] irqchip/irq-rda-intc: Fix return value check in rda8810_intc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a50b4691-2238-1eae-b36d-5e4d152787e2@huawei.com>
Date:   Tue, 18 Dec 2018 21:12:20 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Marc Zyngier <marc.zyngier@....com>, <tglx@...utronix.de>,
        <jason@...edaemon.net>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] irqchip/irq-rda-intc: Fix return value check in
 rda8810_intc_init()


On 2018/12/18 20:58, Marc Zyngier wrote:
> On 18/12/2018 12:15, YueHaibing wrote:
>> In case of error, the function of_io_request_and_map() returns ERR_PTR()
>> and never returns NULL. The NULL test in the return value check should
>> be replaced with IS_ERR().
>>
>> Fixes: d852e62ad689 ("irqchip: Add RDA8810PL interrupt driver")
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  drivers/irqchip/irq-rda-intc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-rda-intc.c b/drivers/irqchip/irq-rda-intc.c
>> index 1176291..f80c424 100644
>> --- a/drivers/irqchip/irq-rda-intc.c
>> +++ b/drivers/irqchip/irq-rda-intc.c
>> @@ -85,7 +85,7 @@ static int __init rda8810_intc_init(struct device_node *node,
>>  				    struct device_node *parent)
>>  {
>>  	rda_intc_base = of_io_request_and_map(node, 0, "rda-intc");
>> -	if (!rda_intc_base)
>> +	if (IS_ERR(rda_intc_base))
>>  		return -ENXIO;
>>  
>>  	/* Mask all interrupt sources */
>>
> 
> Already posted as
> https://lore.kernel.org/lkml/1545047898-153890-1-git-send-email-weiyongjun1@huawei.com/
> 
> You may want to synchronize with your colleagues running the same scripts.

Oh, I missed this. Thank you.

> 
> Thanks,
> 
> 	M.
>