linux-kernel - Re: [PATCH -next] irqchip/irq-rda-intc: Fix return value check in rda8810_intc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcacb2b1-7b49-b6bc-f64a-29f6a21be7f9@arm.com>
Date:   Tue, 18 Dec 2018 12:58:09 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     YueHaibing <yuehaibing@...wei.com>, tglx@...utronix.de,
        jason@...edaemon.net
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] irqchip/irq-rda-intc: Fix return value check in
 rda8810_intc_init()

On 18/12/2018 12:15, YueHaibing wrote:
> In case of error, the function of_io_request_and_map() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
> 
> Fixes: d852e62ad689 ("irqchip: Add RDA8810PL interrupt driver")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/irqchip/irq-rda-intc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-rda-intc.c b/drivers/irqchip/irq-rda-intc.c
> index 1176291..f80c424 100644
> --- a/drivers/irqchip/irq-rda-intc.c
> +++ b/drivers/irqchip/irq-rda-intc.c
> @@ -85,7 +85,7 @@ static int __init rda8810_intc_init(struct device_node *node,
>  				    struct device_node *parent)
>  {
>  	rda_intc_base = of_io_request_and_map(node, 0, "rda-intc");
> -	if (!rda_intc_base)
> +	if (IS_ERR(rda_intc_base))
>  		return -ENXIO;
>  
>  	/* Mask all interrupt sources */
> 

Already posted as
https://lore.kernel.org/lkml/1545047898-153890-1-git-send-email-weiyongjun1@huawei.com/

You may want to synchronize with your colleagues running the same scripts.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...