linux-kernel - Re: [PATCH 14/41] scsi: esas2r: esas2r_init: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7f0fbf6-a793-c22c-cc3e-e35706d722f9@embeddedor.com>
Date:   Wed, 19 Dec 2018 09:39:51 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Bradley Grove <linuxdrivers@...otech.com>
Cc:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/41] scsi: esas2r: esas2r_init: mark expected switch
 fall-throughs

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks
--
Gustavo

On 11/27/18 10:28 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>   drivers/scsi/esas2r/esas2r_init.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/esas2r/esas2r_init.c b/drivers/scsi/esas2r/esas2r_init.c
> index 46b2c83ba21f..950cd92df2ff 100644
> --- a/drivers/scsi/esas2r/esas2r_init.c
> +++ b/drivers/scsi/esas2r/esas2r_init.c
> @@ -1241,6 +1241,7 @@ static bool esas2r_format_init_msg(struct esas2r_adapter *a,
>   			a->init_msg = ESAS2R_INIT_MSG_GET_INIT;
>   			break;
>   		}
> +		/* fall through */
>   
>   	case ESAS2R_INIT_MSG_GET_INIT:
>   		if (msg == ESAS2R_INIT_MSG_GET_INIT) {
> @@ -1254,7 +1255,7 @@ static bool esas2r_format_init_msg(struct esas2r_adapter *a,
>   				esas2r_hdebug("FAILED");
>   			}
>   		}
> -	/* fall through */
> +		/* fall through */
>   
>   	default:
>   		rq->req_stat = RS_SUCCESS;
>