linux-kernel - Re: [PATCH] ACPI/APEI: Clear GHES block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Dec 2018 13:28:39 -0500
From:   Tyler Baicar <baicar.tyler@...il.com>
To:     David Arcari <darcari@...hat.com>
Cc:     Linux ACPI <linux-acpi@...r.kernel.org>,
        Lenny Szubowicz <lszubowi@...hat.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, Tony Luck <tony.luck@...el.com>,
        Borislav Petkov <bp@...en8.de>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Alexandru Gagniuc <mr.nuke.me@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI/APEI: Clear GHES block_status before panic()

On Wed, Dec 19, 2018 at 1:33 PM David Arcari <darcari@...hat.com> wrote:
>
> From: Lenny Szubowicz <lszubowi@...hat.com>
>
> In __ghes_panic() clear the block status in the APEI generic
> error status block for that generic hardware error source before
> calling panic() to prevent a second panic() in the crash kernel
> for exactly the same fatal error.
>
> Otherwise ghes_probe(), running in the crash kernel, would see
> an unhandled error in the APEI generic error status block and
> panic again, thereby precluding any crash dump.
>
> Signed-off-by: Lenny Szubowicz <lszubowi@...hat.com>
> Signed-off-by: David Arcari <darcari@...hat.com>

Good catch!

Tested-by: Tyler Baicar <baicar.tyler@...il.com>