linux-kernel - Re: [PATCH] ACPI/APEI: Clear GHES block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181220192447.GG31403@zn.tnic>
Date:   Thu, 20 Dec 2018 20:24:47 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     David Arcari <darcari@...hat.com>
Cc:     Linux ACPI <linux-acpi@...r.kernel.org>,
        Lenny Szubowicz <lszubowi@...hat.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, Tony Luck <tony.luck@...el.com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Alexandru Gagniuc <mr.nuke.me@...il.com>,
        linux-kernel@...r.kernel.org, James Morse <james.morse@....com>
Subject: Re: [PATCH] ACPI/APEI: Clear GHES block_status before panic()

+ James.

On Wed, Dec 19, 2018 at 11:50:52AM -0500, David Arcari wrote:
> From: Lenny Szubowicz <lszubowi@...hat.com>
> 
> In __ghes_panic() clear the block status in the APEI generic
> error status block for that generic hardware error source before
> calling panic() to prevent a second panic() in the crash kernel
> for exactly the same fatal error.
> 
> Otherwise ghes_probe(), running in the crash kernel, would see
> an unhandled error in the APEI generic error status block and
> panic again, thereby precluding any crash dump.
> 
> Signed-off-by: Lenny Szubowicz <lszubowi@...hat.com>
> Signed-off-by: David Arcari <darcari@...hat.com>
> Cc: Rafael J. Wysocki <rjw@...ysocki.net>
> Cc: Len Brown <lenb@...nel.org>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
> Cc: Alexandru Gagniuc <mr.nuke.me@...il.com>
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/acpi/apei/ghes.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index 02c6fd9..f008ba7 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -691,6 +691,8 @@ static void __ghes_panic(struct ghes *ghes)
>  {
>  	__ghes_print_estatus(KERN_EMERG, ghes->generic, ghes->estatus);
>  
> +	ghes_clear_estatus(ghes);
> +
>  	/* reboot to log the error! */
>  	if (!panic_timeout)
>  		panic_timeout = ghes_panic_timeout;
> -- 

Acked-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.