linux-kernel - Re: [PATCH] rtlwifi: Fix non-working BSS STA mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181220064209.E5AD9606FC@smtp.codeaurora.org>
Date:   Thu, 20 Dec 2018 06:42:09 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     pkshih@...ltek.com, davem@...emloft.net,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Kai-Heng Feng <kai.heng.feng@...onical.com>
Subject: Re: [PATCH] rtlwifi: Fix non-working BSS STA mode

Kai-Heng Feng <kai.heng.feng@...onical.com> wrote:

> Once BSS STA mode gets started, it can be scanned by other clients but
> cannot entablish a connection.
> 
> Turns out the set_bcn_reg() and its *_set_beacon_related_registers()
> callbacks never get called so it has problem beaconing.
> 
> Enable the function in rtl_op_bss_info_changed() can make BSS STA mode
> start to work.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>

The commit log is quite misleading. It implies that the client mode is broken
for all rtlwifi hardware and that can't be the case, otherwise we would be
flooded by bug reports. So please improve the commit log and describe clearly
the problem you are solving.

-- 
https://patchwork.kernel.org/patch/10725537/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches