linux-kernel - Re: [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y38ku24b.fsf@linux.intel.com>
Date:   Thu, 20 Dec 2018 08:46:28 +0200
From:   Felipe Balbi <felipe.balbi@...ux.intel.com>
To:     Rob Herring <robh@...nel.org>, Chen Yu <chenyu56@...wei.com>
Cc:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, wangbinghui@...ilicon.com,
        suzhuangluan@...ilicon.com, kongfei@...ilicon.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Rutland <mark.rutland@....com>,
        John Stultz <john.stultz@...aro.org>
Subject: Re: [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs


Hi,

Rob Herring <robh@...nel.org> writes:
>> >>>> +Example:
>> >>>> +    usb3: hisi_dwc3 {
>> >>>> +        compatible = "hisilicon,hi3660-dwc3";
>> >>>> +        #address-cells = <2>;
>> >>>> +        #size-cells = <2>;
>> >>>> +        ranges;
>> >>>> +
>> >>>> +        clocks = <&crg_ctrl HI3660_CLK_ABB_USB>,
>> >>>> +             <&crg_ctrl HI3660_ACLK_GATE_USB3OTG>;
>> >>>> +        clock-names = "clk_usb3phy_ref", "aclk_usb3otg";
>> >>>> +        assigned-clocks = <&crg_ctrl HI3660_ACLK_GATE_USB3OTG>;
>> >>>> +        assigned-clock-rates = <229000000>;
>> >>>> +        resets = <&crg_rst 0x90 8>,
>> >>>> +             <&crg_rst 0x90 7>,
>> >>>> +             <&crg_rst 0x90 6>,
>> >>>> +             <&crg_rst 0x90 5>;
>> >>>> +
>> >>>> +        dwc3: dwc3@...00000 {
>
> Please combine these into a single node. Unless you have a wrapper with 
> registers, you don't need these 2 nodes. Clocks and reset can go in the 
> dwc3 node.
>
>> >>>
>> >>>      According to the DT spec, the node names should be generic, not chip specific, i.e. usb@...00000 in this case.
>> >>>
>> >>
>> >> Do you mean it should be usb@...00000: dwc3@...00000 ?
>> > 
>> >     dwc3: usb@...00000
>> > 
>> >    "dwc3:" is a label, not name.
>> 
>> I use the node name "dwc3@...00000" according to Documentation/devicetree/bindings/usb/dwc3.txt
>> and documentations of vendor drivers, i.e. qcom,dwc3.txt, rockchip,dwc3.txt.
>> 
>> In these documentations, the dwc3 sub-node name uses "dwc3@...xxxxx".
>> 
>> I think it is better to be same as the other vendor's dwc3 drivers.
>
> It's not. The other bindings are wrong. Follow the DT Spec.

what's wrong about them? They clearly describe the HW:

1) a company-specific glue/adaptation/integration IP
2) a generic licensed IP inside it

dwc3.ko is compatible with Synopsys' documentation and there's only one
incarnation of dwc3. Everything that can be detected in runtime, we do
so. Everything that can't, we use quirk flags. Keep in mind dwc3.ko is
also used as is by non-DT systems where we can't simply change a
compatible flag.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)