lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Dec 2018 11:45:37 +0100 From: Richard Weinberger <richard@....at> To: Hou Tao <houtao1@...wei.com> Cc: linux-mtd@...ts.infradead.org, dwmw2@...radead.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH] jffs2: Fix integer underflow in jffs2_rtime_compress Am Donnerstag, 20. Dezember 2018, 11:43:08 CET schrieb Hou Tao: > > On 2018/12/16 0:23, Richard Weinberger wrote: > > The rtime compressor assumes that at least two bytes are > > compressed. > > If we try to compress just one byte, the loop condition will > > wrap around and an out-of-bounds write happens. > > > > Cc: <stable@...r.kernel.org> > > Signed-off-by: Richard Weinberger <richard@....at> > > --- > > fs/jffs2/compr_rtime.c | 3 +++ > > 1 file changed, 3 insertions(+) > > It seems that it doesn't incur any harm because the minimal allocated > size will be 8-bytes and jffs2_rtime_compress() will write 2-bytes into > the allocated buffer. Are you sure about that? I saw odd kernel behavior and KASAN complained too. Thanks, //richard
Powered by blists - more mailing lists