linux-kernel - Re: [PATCH -next] regulator: act8945a-regulator: make symbol act8945a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181220114550.782cdddc@bbrezillon>
Date:   Thu, 20 Dec 2018 11:45:50 +0100
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH -next] regulator: act8945a-regulator: make symbol
 act8945a_pm static

On Tue, 18 Dec 2018 07:10:21 +0000
Wei Yongjun <weiyongjun1@...wei.com> wrote:

> Fixes the following sparse warning:
> 
> drivers/regulator/act8945a-regulator.c:340:1: warning:
>  symbol 'act8945a_pm' was not declared. Should it be static?
> 
> Fixes: 7482d6ecc68e ("regulator: act8945a-regulator: Implement PM functionalities")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Reviewed-by: Boris Brezillon <boris.brezillon@...tlin.com>

> ---
>  drivers/regulator/act8945a-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/act8945a-regulator.c b/drivers/regulator/act8945a-regulator.c
> index 90572b6..dc3942b 100644
> --- a/drivers/regulator/act8945a-regulator.c
> +++ b/drivers/regulator/act8945a-regulator.c
> @@ -337,7 +337,7 @@ static int act8945a_suspend(struct device *pdev)
>  	return regmap_write(act8945a->regmap, ACT8945A_SYS_CTRL, 0x42);
>  }
>  
> -SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);
> +static SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);
>  
>  static void act8945a_pmic_shutdown(struct platform_device *pdev)
>  {
> 
> 
>