linux-kernel - Re: [PATCH] x86/cpu: sort cpuinfo flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181220120743.wnb766yemn7xqrjq@kshutemo-mobl1>
Date:   Thu, 20 Dec 2018 15:07:43 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Dave Hansen <dave.hansen@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/cpu: sort cpuinfo flags

On Wed, Dec 19, 2018 at 11:50:14AM -0800, Dave Hansen wrote:
> @@ -96,15 +168,11 @@ static int show_cpuinfo(struct seq_file
>  
>  	show_cpuinfo_core(m, c, cpu);
>  	show_cpuinfo_misc(m, c);
> -
> -	seq_puts(m, "flags\t\t:");
> -	for (i = 0; i < 32*NCAPINTS; i++)
> -		if (cpu_has(c, i) && x86_cap_flags[i] != NULL)
> -			seq_printf(m, " %s", x86_cap_flags[i]);
> +	show_cpuinfo_flags(m, c);
>  
>  	seq_puts(m, "\nbugs\t\t:");
>  	for (i = 0; i < 32*NBUGINTS; i++) {
> -		unsigned int bug_bit = 32*NCAPINTS + i;
> +		unsigned int bug_bit = x86_NR_CAPS + i;

s/x86_NR_CAPS/X86_NR_CAPS/

>  
>  		if (cpu_has_bug(c, bug_bit) && x86_bug_flags[i])
>  			seq_printf(m, " %s", x86_bug_flags[i]);
> _

-- 
 Kirill A. Shutemov