linux-kernel - Re: [PATCH 04/14] drm/bochs: atomic: add mode_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bed74701-ac73-d8ed-866e-29f8017ca6f0@gmail.com>
Date:   Thu, 20 Dec 2018 14:08:28 +0200
From:   Oleksandr Andrushchenko <andr2000@...il.com>
To:     Gerd Hoffmann <kraxel@...hat.com>, dri-devel@...ts.freedesktop.org,
        David Airlie <airlied@...hat.com>
Cc:     David Airlie <airlied@...ux.ie>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" 
        <virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH 04/14] drm/bochs: atomic: add mode_set_nofb callback.


On 12/19/18 1:51 PM, Gerd Hoffmann wrote:
> Conversion to atomic modesetting, step two.
> Add mode_set_nofb crtc helper callback.
>
> Signed-off-by: Gerd Hoffmann <kraxel@...hat.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>
> ---
>   drivers/gpu/drm/bochs/bochs_kms.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c
> index 59d469f343..18b705fb0b 100644
> --- a/drivers/gpu/drm/bochs/bochs_kms.c
> +++ b/drivers/gpu/drm/bochs/bochs_kms.c
> @@ -86,6 +86,14 @@ static int bochs_crtc_mode_set(struct drm_crtc *crtc,
>   	return 0;
>   }
>   
> +static void bochs_crtc_mode_set_nofb(struct drm_crtc *crtc)
> +{
> +	struct bochs_device *bochs =
> +		container_of(crtc, struct bochs_device, crtc);
> +
> +	bochs_hw_setmode(bochs, &crtc->mode);
> +}
> +
>   static void bochs_crtc_prepare(struct drm_crtc *crtc)
>   {
>   }
> @@ -149,6 +157,7 @@ static const struct drm_crtc_helper_funcs bochs_helper_funcs = {
>   	.dpms = bochs_crtc_dpms,
>   	.mode_set = bochs_crtc_mode_set,
>   	.mode_set_base = bochs_crtc_mode_set_base,
> +	.mode_set_nofb = bochs_crtc_mode_set_nofb,
>   	.prepare = bochs_crtc_prepare,
>   	.commit = bochs_crtc_commit,
>   	.atomic_enable = bochs_crtc_atomic_enable,