linux-kernel - Re: [PATCH 2/2] Staging: iio: adis16203: fixed a SPDX identifier tag mistake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181222173302.1204162e@archlinux>
Date:   Sat, 22 Dec 2018 17:33:02 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Amir Mahdi Ghorbanian <indigoomega021@...il.com>
Cc:     lars@...afoo.de, Michael.Hennerich@...log.com, knaack.h@....de,
        pmeerw@...erw.net, gregkh@...uxfoundation.org,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging: iio: adis16203: fixed a SPDX identifier
 tag mistake

On Thu, 20 Dec 2018 15:46:53 -0800
Amir Mahdi Ghorbanian <indigoomega021@...il.com> wrote:

> Fixed a coding style mistake by adding the SPDX identifier tag to the
> first line of the code
> 
> Signed-off-by: Amir Mahdi Ghorbanian <indigoomega021@...il.com>
Two things.  It's not a 'mistake' as this driver massively predates the use of
SPDX tags!  Also, there is a problem here as it's current licensing is
inconsistent.  The MODULE_LICENSE is GPL-2.0 which would be GPL-2.0 (no +)
but the original comment was +.

Michael, do you want to take a view on this one?  Copyright is Analog's
so should be fine if you say what is preferred.

Thanks,

Jonathan

> ---
>  drivers/staging/iio/accel/adis16203.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
> index 5cc96c80..4ae5b74 100644
> --- a/drivers/staging/iio/accel/adis16203.c
> +++ b/drivers/staging/iio/accel/adis16203.c
> @@ -1,9 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0+
>  /*
>   * ADIS16203 Programmable 360 Degrees Inclinometer
>   *
>   * Copyright 2010 Analog Devices Inc.
>   *
> - * Licensed under the GPL-2 or later.
>   */
>  
>  #include <linux/delay.h>