linux-kernel - Re: [PATCH 2/2] USB: storage: add quirk for SMI SM3350

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Dec 2018 22:38:33 +0800
From:   Icenowy Zheng <icenowy@...c.io>
To:     Alan Stern <stern@...land.harvard.edu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org
Subject: Re: [PATCH 2/2] USB: storage: add quirk for SMI SM3350

在 2018-12-27四的 22:34 +0800，Icenowy Zheng写道：
> The SMI SM3350 USB-UFS bridge controller cannot handle long sense
> request
> correctly and will make the chip refuse to do read/write when
> requested
> long sense.
> 
> Add a bad sense quirk for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy@...c.io>
> ---

I forgot to:

Cc: stable@...r.kernel.org

>  drivers/usb/storage/unusual_devs.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h
> b/drivers/usb/storage/unusual_devs.h
> index f7f83b21dc74..ea0d27a94afe 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -1265,6 +1265,18 @@ UNUSUAL_DEV( 0x090c, 0x1132, 0x0000, 0xffff,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_FIX_CAPACITY ),
>  
> +/*
> + * Reported by Icenowy Zheng <icenowy@...c.io>
> + * The SMI SM3350 USB-UFS bridge controller will enter a wrong state
> + * that do not process read/write command if a long sense is
> requested,
> + * so force to use 18-byte sense.
> + */
> +UNUSUAL_DEV(  0x090c, 0x3350, 0x0000, 0xffff,
> +		"SMI",
> +		"SM3350 UFS-to-USB-Mass-Storage bridge",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_BAD_SENSE ),
> +
>  /*
>   * Reported by Paul Hartman <paul.hartman+linux@...il.com>
>   * This card reader returns "Illegal Request, Logical Block Address