linux-kernel - Re: + proc-commit-to-genradix.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20181227144643.GA6925@avx2>
Date:   Thu, 27 Dec 2018 17:46:43 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     akpm@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org, willy@...radead.org,
        vyasevich@...il.com, viro@...iv.linux.org.uk, shli@...nel.org,
        sds@...ho.nsa.gov, pshelar@....org, paul@...l-moore.com,
        nhorman@...driver.com, marcelo.leitner@...il.com,
        eparis@...isplace.org, dave.hansen@...el.com,
        kent.overstreet@...il.com
Subject: Re: + proc-commit-to-genradix.patch added to -mm tree

On Mon, Dec 17, 2018 at 12:54:58PM -0800, akpm@...ux-foundation.org wrote:
>     http://ozlabs.org/~akpm/mmots/broken-out/proc-commit-to-genradix.patch
> Subject: proc: commit to genradix
> 
> The new generic radix trees have a simpler API and implementation, and no
> limitations on number of elements, so all flex_array users are being
> converted

> --- a/fs/proc/base.c~proc-commit-to-genradix
> +++ a/fs/proc/base.c
> @@ -2142,11 +2142,12 @@ proc_map_files_readdir(struct file *file
>  	struct task_struct *task;
>  	struct mm_struct *mm;
>  	unsigned long nr_files, pos, i;
> -	struct flex_array *fa = NULL;
> -	struct map_files_info info;
> +	GENRADIX(struct map_files_info) fa;
>  	struct map_files_info *p;
>  	int ret;
>  
> +	genradix_init(&fa);

Reviewed-by: Alexey Dobriyan <adobriyan@...il.com>

I'll try to check performance after New Year.