linux-kernel - [PATCH 1/2] perf c2c: Change the default coalesce setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181228101820.28010-1-jolsa@kernel.org>
Date:   Fri, 28 Dec 2018 11:18:19 +0100
From:   Jiri Olsa <jolsa@...nel.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Joe Mario <jmario@...hat.com>
Subject: [PATCH 1/2] perf c2c: Change the default coalesce setup

Joe suggested to have the coalesce default set just to 'iaddr',
because it's easier to read on the (default) c2c report run.

By removing pid from -c option, the c2c report will group all
the relevant pids under instruction address bucket. User can
always run -c pid,iaddr for more grained output on particular
pids.

Suggested-by: Joe Mario <jmario@...hat.com>
Link: http://lkml.kernel.org/n/tip-lk53c7y9fadu53spuzsn6cij@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@...nel.org>
---
 tools/perf/builtin-c2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 686fb60a8e11..321687f8f373 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -68,7 +68,7 @@ struct c2c_hist_entry {
 	struct hist_entry	he;
 };
 
-static char const *coalesce_default = "pid,iaddr";
+static char const *coalesce_default = "iaddr";
 
 struct perf_c2c {
 	struct perf_tool	tool;
-- 
2.17.2