linux-kernel - Re: [PATCH] proc: return exit code 4 for skipped tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <87zhsahm1s.fsf@morokweng.localdomain>
Date:   Tue, 08 Jan 2019 19:33:19 -0200
From:   Thiago Jung Bauermann <bauerman@...ux.ibm.com>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] proc: return exit code 4 for skipped tests


Alexey Dobriyan <adobriyan@...il.com> writes:

> Test harness uses 4 for SKIP, not 2.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
>
>  tools/testing/selftests/proc/proc-loadavg-001.c        |    2 +-
>  tools/testing/selftests/proc/proc-self-map-files-002.c |    2 +-
>  tools/testing/selftests/proc/proc-self-syscall.c       |    2 +-
>  tools/testing/selftests/proc/proc-self-wchan.c         |    2 +-
>  tools/testing/selftests/proc/read.c                    |    2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
>
> --- a/tools/testing/selftests/proc/proc-loadavg-001.c
> +++ b/tools/testing/selftests/proc/proc-loadavg-001.c
> @@ -30,7 +30,7 @@ int main(void)
>
>  	if (unshare(CLONE_NEWPID) == -1) {
>  		if (errno == ENOSYS || errno == EPERM)
> -			return 2;
> +			return 4;
>  		return 1;
>  	}

Can't these tests use the KSFT_SKIP macro defined in kselftest.h?

--
Thiago Jung Bauermann
IBM Linux Technology Center