linux-kernel - Re: [PATCH] proc: return exit code 4 for skipped tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190114201155.GA9978@avx2>
Date:   Mon, 14 Jan 2019 23:11:55 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     Thiago Jung Bauermann <bauerman@...ux.ibm.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] proc: return exit code 4 for skipped tests

On Tue, Jan 08, 2019 at 07:33:19PM -0200, Thiago Jung Bauermann wrote:
> Alexey Dobriyan <adobriyan@...il.com> writes:
> > --- a/tools/testing/selftests/proc/proc-loadavg-001.c
> > +++ b/tools/testing/selftests/proc/proc-loadavg-001.c
> > @@ -30,7 +30,7 @@ int main(void)
> >
> >  	if (unshare(CLONE_NEWPID) == -1) {
> >  		if (errno == ENOSYS || errno == EPERM)
> > -			return 2;
> > +			return 4;
> >  		return 1;
> >  	}
> 
> Can't these tests use the KSFT_SKIP macro defined in kselftest.h?

They can! I tried to find a single use of XPASS and XFAIL and failed and
now I just don't want to have anything to do with that header.