linux-kernel - Re: [PATCH] m68k: Avoid VLA use in mangle_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2aFOXdmheM3BMx=rB6AT-3yEXcxfCxt_9o5dWqu_qLYA@mail.gmail.com>
Date:   Tue, 8 Jan 2019 14:36:27 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k: Avoid VLA use in mangle_kernel_stack()

On Mon, Jan 7, 2019 at 10:29 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> With gcc 7.3.0:
>
>     arch/m68k/kernel/signal.c: In function ‘mangle_kernel_stack’:
>     arch/m68k/kernel/signal.c:654:3: warning: ISO C90 forbids variable length array ‘buf’ [-Wvla]
>        unsigned long buf[fsize / 2]; /* yes, twice as much */
>        ^~~~~~~~
>
> Replace the variable size by the upper limit, which is 168 bytes.
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Acked-by: Arnd Bergmann <arnd@...db.de>

I also have a couple of build warning fixes for m68k that I might
post in the next few days, for stuff that I ran into while testing my
y2038 series.

      Arnd