linux-kernel - Re: [PATCH] m68k: Avoid VLA use in mangle_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXBujvRZcurEP60VNYZPrJcO1-N6RWXhpsTEZ5r14e28g@mail.gmail.com>
Date:   Mon, 21 Jan 2019 10:41:36 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     linux-m68k <linux-m68k@...ts.linux-m68k.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k: Avoid VLA use in mangle_kernel_stack()

On Mon, Jan 7, 2019 at 10:29 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> With gcc 7.3.0:
>
>     arch/m68k/kernel/signal.c: In function ‘mangle_kernel_stack’:
>     arch/m68k/kernel/signal.c:654:3: warning: ISO C90 forbids variable length array ‘buf’ [-Wvla]
>        unsigned long buf[fsize / 2]; /* yes, twice as much */
>        ^~~~~~~~
>
> Replace the variable size by the upper limit, which is 168 bytes.
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Thanks, applied and queued for v5.1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds