linux-kernel - [PATCH v4 2/2] kobject: drop newline from msg string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2ba5177197f8b40e399867ea1f1aee2920c3cb49.1546915794.git.tsu.yubo@gmail.com>
Date:   Mon,  7 Jan 2019 22:11:35 -0500
From:   Bo YU <tsu.yubo@...il.com>
To:     gregkh@...uxfoundation.org, rafael@...nel.org
Cc:     Bo YU <tsu.yubo@...il.com>, linux-kernel@...r.kernel.org,
        joe@...ches.com, yuzibode@....com
Subject: [PATCH v4 2/2] kobject: drop newline from msg string

There is currently a missing terminating newline in non-switch case
match,when msg == NULL

Signed-off-by: Bo YU <tsu.yubo@...il.com>
---
Changes in V4:
Recovery  originly declaration, requested by Greg.

Changes in V3:
Improve the commit log, requested by rafael.

Changes in V2:
According to Joe's suggestion, drop newline from msg string
---
 lib/kobject_uevent.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 499dfcdafcb0..118226a02707 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -200,7 +200,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
 
 	r = kobject_action_type(buf, count, &action, &action_args);
 	if (r) {
-		msg = "unknown uevent action string\n";
+		msg = "unknown uevent action string";
 		goto out;
 	}
 
@@ -212,7 +212,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
 	r = kobject_action_args(action_args,
 				count - (action_args - buf), &env);
 	if (r == -EINVAL) {
-		msg = "incorrect uevent action arguments\n";
+		msg = "incorrect uevent action arguments";
 		goto out;
 	}
 
@@ -224,7 +224,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
 out:
 	if (r) {
 		devpath = kobject_get_path(kobj, GFP_KERNEL);
-		pr_warn("synth uevent: %s: %s",
+		pr_warn("synth uevent: %s: %s\n",
 		       devpath ?: "unknown device",
 		       msg ?: "failed to send uevent");
 		kfree(devpath);
-- 
2.11.0