linux-kernel - Re: [RFC PATCH v1] cfg80211/nl80211: add support for AID assignment by driver : https://patchwork.kernel.org/patch/10726899/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a7kbqd6s.fsf@kamboji.qca.qualcomm.com>
Date:   Tue, 08 Jan 2019 19:19:55 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     "Garnayak\, Sarada Prasanna" <sarada.prasanna.garnayak@...el.com>
Cc:     "Berg\, Johannes" <johannes.berg@...el.com>,
        Jouni Malinen <j@...fi>,
        Sergey Matyukevich <sergey.matyukevich.os@...ntenna.com>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-wireless@...r.kernel.org
Subject: Re: [RFC PATCH v1] cfg80211/nl80211: add support for AID assignment by driver : https://patchwork.kernel.org/patch/10726899/

+ linux-wireless

"Garnayak, Sarada Prasanna" <sarada.prasanna.garnayak@...el.com> writes:

> Thank you so much for reviewing my RFC patch and here I would like to
> address the big concerns/comments about this RFC patch like 
>
> Ø What are the exact use case and potential user of this patch.
>
> Ø How the Hostapd will handle this get aid and free aid.
>
> Ø etc.
>
> In the current implementation in WLAN Stack, the hostapd is assigning
> the AID for a station during association. 
>
> But we have a few WLAN hardware which is maintaining the AID in the
> WLAN hardware level itself and the firmware checking this AID in the
> hardware level according to that the firmware is taking action on
> station management
>
> like (Station DB management, BA agreement, SMPS and TM management
> frame etc....). For this reason, we need these get_aid/free_aid. 
>
> Also here I am attaching the Hostapd RFC Patch for the same. PFA
> (hostapd patch, call flow diagram and comments on this kernel patch)
>
> Please review the call flow below:

You made few crucial mistakes:

1. You did not CC linux-wireless.

2. You submitted the message as HTML and our lists automatically filter
   those.

3. You attached a powerpoint file and I would hope that our lists
   automatically filter those as well. At least I'm not going to open
   any random powerpoint/word files I receive via email.

-- 
Kalle Valo