linux-kernel - Re: [PATCH] kobject: make kset_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jkwANa_Yy98tmZmm0HgztGP5ATFy4FVUNxxkM2hkW7_A@mail.gmail.com>
Date:   Wed, 9 Jan 2019 10:24:45 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kobject: make kset_get_ownership() 'static'

On Wed, Jan 9, 2019 at 8:38 AM Eric Biggers <ebiggers@...nel.org> wrote:
>
> From: Eric Biggers <ebiggers@...gle.com>
>
> kset_get_ownership() is only used in lib/kobject.c, so make it 'static'.
>
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

> ---
>  lib/kobject.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/kobject.c b/lib/kobject.c
> index b72e00fd7d09e..aa89edcd2b63a 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -887,7 +887,7 @@ static void kset_release(struct kobject *kobj)
>         kfree(kset);
>  }
>
> -void kset_get_ownership(struct kobject *kobj, kuid_t *uid, kgid_t *gid)
> +static void kset_get_ownership(struct kobject *kobj, kuid_t *uid, kgid_t *gid)
>  {
>         if (kobj->parent)
>                 kobject_get_ownership(kobj->parent, uid, gid);
> --
> 2.20.1
>