[<prev] [next>] [day] [month] [year] [list]
Message-Id: <1547000188-2732-1-git-send-email-vincent.guittot@linaro.org>
Date: Wed, 9 Jan 2019 03:16:28 +0100
From: Vincent Guittot <vincent.guittot@...aro.org>
To: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
rjw@...ysocki.net, ulf.hansson@...aro.org, tony@...mide.com
Cc: Vincent Guittot <vincent.guittot@...aro.org>
Subject: [PATCH] PM/runtime: Fix autosuspend_delay on 32bits arch
Cast autosuspend_delay in u64 to make sure that the full computation of
expires will be done in u64, even on 32bits arch.
Otherwise, any delay greater than 2^31 nsec can overflow if signed 32bits
is used when moving delay from msec to nsec
Fixes: 8234f6734c5d ("PM-runtime: Switch autosuspend over to using hrtimers")
Reported-by: Tony Lindgren <tony@...mide.com>
Tested-by: Tony Lindgren <tony@...mide.com>
Signed-off-by: Vincent Guittot <vincent.guittot@...aro.org>
---
drivers/base/power/runtime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
index 7062469..44c5c76 100644
--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -141,7 +141,7 @@ u64 pm_runtime_autosuspend_expiration(struct device *dev)
last_busy = READ_ONCE(dev->power.last_busy);
- expires = last_busy + autosuspend_delay * NSEC_PER_MSEC;
+ expires = last_busy + (u64)(autosuspend_delay) * NSEC_PER_MSEC;
if (expires <= now)
expires = 0; /* Already expired. */
--
2.7.4
Powered by blists - more mailing lists