linux-kernel - Re: [PATCH v2] kernel: release ptraced tasks before zap_pid_ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190110153747.75787a99b380f415ee38d145@linux-foundation.org>
Date:   Thu, 10 Jan 2019 15:37:47 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Andrei Vagin <avagin@...il.com>
Cc:     Oleg Nesterov <oleg@...hat.com>, linux-kernel@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH v2] kernel: release ptraced tasks before
 zap_pid_ns_processes

On Thu, 10 Jan 2019 09:52:00 -0800 Andrei Vagin <avagin@...il.com> wrote:

> Currently, exit_ptrace() adds all ptraced tasks in a dead list, than
> zap_pid_ns_processes() waits all tasks in a current pidns, and only
> then tasks from the dead list are released.
> 
> zap_pid_ns_processes() can stuck on waiting tasks from the dead list. In
> this case, we will have one unkillable process with one or more dead
> children.
> 
> Thanks to Oleg for the advice to release tasks in find_child_reaper().
> 
> Fixes: 7c8bd2322c7f ("exit: ptrace: shift "reap dead" code from exit_ptrace() to forget_original_parent()")
> 
> Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>
> Signed-off-by: Andrei Vagin <avagin@...il.com>

Does this warrant a -stable backport?  7c8bd2322c7f was 4+ years ago...