linux-kernel - Re: [PATCH 2/2] regulator: max77620: disable notifier events for FPS rails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190110120707.GD9541@sirena.org.uk>
Date:   Thu, 10 Jan 2019 12:07:07 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Mark Zhang <markz@...dia.com>
Cc:     lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org,
        Venkat Reddy Talla <vreddytalla@...dia.com>
Subject: Re: [PATCH 2/2] regulator: max77620: disable notifier events for FPS
 rails

On Thu, Jan 10, 2019 at 12:11:17PM +0800, Mark Zhang wrote:

> +		/* there is no SW control for rails which are part of FPS
> +		 * set always no contraint to true to avoid regulator
> +		 * enable/disable notification
> +		 */
> +		if (pmic->reg_pdata[id].active_fps_src != MAX77620_FPS_SRC_NONE)
> +			rdev->constraints->always_on = true;

A driver should never modify the constraints, you should register a
different set of operations without an enable operation instead and let
the framework handle this.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)