linux-kernel - Re: [PATCH 2/2] regulator: max77620: disable notifier events for FPS rails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Jan 2019 21:35:05 +0800
From:   Mark Zhang <markz@...dia.com>
To:     Mark Brown <broonie@...nel.org>
CC:     <lgirdwood@...il.com>, <linux-kernel@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>,
        Venkat Reddy Talla <vreddytalla@...dia.com>
Subject: Re: [PATCH 2/2] regulator: max77620: disable notifier events for FPS
 rails

On 1/10/2019 8:07 PM, Mark Brown wrote:
> On Thu, Jan 10, 2019 at 12:11:17PM +0800, Mark Zhang wrote:
> 
>> +		/* there is no SW control for rails which are part of FPS
>> +		 * set always no contraint to true to avoid regulator
>> +		 * enable/disable notification
>> +		 */
>> +		if (pmic->reg_pdata[id].active_fps_src != MAX77620_FPS_SRC_NONE)
>> +			rdev->constraints->always_on = true;
> 
> A driver should never modify the constraints, you should register a
> different set of operations without an enable operation instead and let
> the framework handle this.

Oh right, today I checked the codes based on your suggestion so I think we don't need this patch now. We can find another way to fix our issue without touching the framework constraints. Thanks.

Mark

>