linux-kernel - Re: [PATCH 1/2] ARM: integrator: impd1: fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaEP=nnE5SQE0OZ7Mi_VCnVn9AK9bGu2tJ5XR3+uFHfvg@mail.gmail.com>
Date:   Fri, 11 Jan 2019 13:22:35 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Nicholas Mc Guire <hofrat@...dl.org>
Cc:     Russell King <linux@...linux.org.uk>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ARM: integrator: impd1: fix NULL pointer dereference

On Fri, Jan 4, 2019 at 6:18 PM Gustavo A. R. Silva
<gustavo@...eddedor.com> wrote:

> There is a potential NULL pointer dereference in case devm_kzalloc()
> fails and returns NULL.
>
> Fix this by adding a NULL check on lookup.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: 684284b64aae ("ARM: integrator: add MMCI device to IM-PD1")
> Cc: stable@...r.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

I already have a patch fixing this from Nicholas Mc Guire, just that I
forgot to push it upstream. I'll fix, sorry for not applying his patch
earlier.

Yours,
Linus Walleij