linux-kernel - Re: [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190114232608.GL11073@sirena.org.uk>
Date:   Mon, 14 Jan 2019 23:26:08 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Rohit kumar <rohitkr@...eaurora.org>
Cc:     plai@...eaurora.org, bgoswami@...eaurora.org,
        asishb@...eaurora.org, lgirdwood@...il.com, perex@...ex.cz,
        tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, rohkumar@....qualcomm.com,
        srinivas.kandagatla@...aro.org, vinod.koul@...aro.org,
        Ajit Pandey <ajitp@...eaurora.org>
Subject: Re: [PATCH] ASoC: soc-core: Fix null pointer dereference in
 soc_find_component

On Fri, Jan 11, 2019 at 01:44:02PM +0530, Rohit kumar wrote:

> -	if (!soc_find_component(link->platform->of_node, link->platform->name))
> -		return -EPROBE_DEFER;
> +	if (link->platform->of_node || link->platform->name)
> +		if (!soc_find_component(link->platform->of_node,
> +					link->platform->name))
> +			return -EPROBE_DEFER;

If we need to do this for every user (which we do pretty much it seems)
we should just be doing it inside find_component().

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)