linux-kernel - Re: [PATCH] ARM: VDSO: Drop implicit common-page-size linker flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdnZcHdV6H1H74mRGbVayYwbpU0AmX0nwhEJHYmKVuvo5Q@mail.gmail.com>
Date:   Mon, 14 Jan 2019 13:50:29 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Russell King <linux@...linux.org.uk>,
        Mark Rutland <mark.rutland@....com>
Cc:     Dmitry Vyukov <dvyukov@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: VDSO: Drop implicit common-page-size linker flag

On Mon, Dec 10, 2018 at 2:32 PM <ndesaulniers@...gle.com> wrote:
>
> GNU linker's -z common-page-size's default value is based on the target
> architecture. arch/arm/vdso/Makefile sets it to the architecture
> default, which is implicit and redundant. Drop it.
>
> Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com
> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
> ---
>  arch/arm/vdso/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile
> index f4efff9d3afb..8f2fac5acbc8 100644
> --- a/arch/arm/vdso/Makefile
> +++ b/arch/arm/vdso/Makefile
> @@ -11,7 +11,7 @@ ccflags-y := -fPIC -fno-common -fno-builtin -fno-stack-protector
>  ccflags-y += -DDISABLE_BRANCH_PROFILING
>
>  VDSO_LDFLAGS := -Wl,-Bsymbolic -Wl,--no-undefined -Wl,-soname=linux-vdso.so.1
> -VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096
> +VDSO_LDFLAGS += -Wl,-z,max-page-size=4096
>  VDSO_LDFLAGS += -nostdlib -shared
>  VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
>  VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--build-id)
> --
> 2.20.0.rc2.403.gdbc3b29805-goog
>

Bumping for review.  This option has been removed from all other architectures.

-- 
Thanks,
~Nick Desaulniers