linux-kernel - Re: [PATCH] video: offb: annotate implicit fall throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15854ad8-7bd5-ede7-6ce4-00122d6ba279@embeddedor.com>
Date:   Mon, 14 Jan 2019 15:50:34 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Mathieu Malaterre <malat@...ian.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: offb: annotate implicit fall throughs



On 1/14/19 2:40 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings (W=1). Fix them up.
> 
> This commit remove the following warnings:
> 
>    drivers/video/fbdev/offb.c:211:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    drivers/video/fbdev/offb.c:142:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>

Acked-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Thanks
--
Gustavo

> ---
>   drivers/video/fbdev/offb.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> index 31f769d67195..e0f0c5351306 100644
> --- a/drivers/video/fbdev/offb.c
> +++ b/drivers/video/fbdev/offb.c
> @@ -141,6 +141,7 @@ static int offb_setcolreg(u_int regno, u_int red, u_int green, u_int blue,
>   		/* Clear PALETTE_ACCESS_CNTL in DAC_CNTL */
>   		out_le32(par->cmap_adr + 0x58,
>   			 in_le32(par->cmap_adr + 0x58) & ~0x20);
> +		/* fall through */
>   	case cmap_r128:
>   		/* Set palette index & data */
>   		out_8(par->cmap_adr + 0xb0, regno);
> @@ -210,6 +211,7 @@ static int offb_blank(int blank, struct fb_info *info)
>   				/* Clear PALETTE_ACCESS_CNTL in DAC_CNTL */
>   				out_le32(par->cmap_adr + 0x58,
>   					 in_le32(par->cmap_adr + 0x58) & ~0x20);
> +				/* fall through */
>   			case cmap_r128:
>   				/* Set palette index & data */
>   				out_8(par->cmap_adr + 0xb0, i);
>