lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 15 Jan 2019 18:20:09 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     George Hilliard <thirtythreeforty@...il.com>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        NeilBrown <neil@...wn.name>, sergio.paracuellos@...il.com
Subject: Re: [PATCH v3] staging: Mediatek: Use individual config flags in
 Makefile

On Tue, Jan 15, 2019 at 10:02:21AM -0700, George Hilliard wrote:
> These drivers can be useful on other MT76xx SoCs, which have compatible
> peripherals.  The drivers were selectable in Kconfig, but they were
> quietly excluded from the build because the SOC_MT7621 chip was not
> selected.  So, make the Makefiles use the same flags as Kconfig for
> these drivers.
> 
> mt7621-dma and mt7621-dts are left alone because they truly do require
> that SoC.
> 
> I have personally confirmed that the mt7621-spi driver works on the
> MT7688, which was what prompted this change.
> 
> Cc: linux-kernel@...r.kernel.org
> Cc: devel@...verdev.osuosl.org
> Cc: NeilBrown <neil@...wn.name>
> Cc: sergio.paracuellos@...il.com
> Signed-off-by: George Hilliard <thirtythreeforty@...il.com>
> ---
>  drivers/staging/Makefile                | 14 +++++++-------
>  drivers/staging/mt7621-pci-phy/Makefile |  2 +-
>  drivers/staging/mt7621-pci/Makefile     |  2 +-
>  3 files changed, 9 insertions(+), 9 deletions(-)

What changed from v2 and v1?  That always goes below the --- line.

Please fix that up and resend v4.

thanks,

greg k-h

Powered by blists - more mailing lists