linux-kernel - Re: [PATCH 4/4] dax: "Hotplug" persistent memory for use like normal RAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Jan 2019 13:53:03 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>
Cc:     dave@...1.net, Dan Williams <dan.j.williams@...el.com>,
        Dave Jiang <dave.jiang@...el.com>, zwisler@...nel.org,
        vishal.l.verma@...el.com, thomas.lendacky@....com,
        Andrew Morton <akpm@...ux-foundation.org>, mhocko@...e.com,
        linux-nvdimm@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-mm@...ck.org, Huang Ying <ying.huang@...el.com>,
        Wu Fengguang <fengguang.wu@...el.com>,
        Borislav Petkov <bp@...e.de>, baiyaowei@...s.chinamobile.com,
        Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH 4/4] dax: "Hotplug" persistent memory for use like normal
 RAM

On 1/16/19 1:16 PM, Bjorn Helgaas wrote:
>> +       /*
>> +        * Set flags appropriate for System RAM.  Leave ..._BUSY clear
>> +        * so that add_memory() can add a child resource.
>> +        */
>> +       new_res->flags = IORESOURCE_SYSTEM_RAM;
> IIUC, new_res->flags was set to "IORESOURCE_MEM | ..." in the
> devm_request_mem_region() path.  I think you should keep at least
> IORESOURCE_MEM so the iomem_resource tree stays consistent.

I went to look at fixing this.  It looks like "IORESOURCE_SYSTEM_RAM"
includes IORESOURCE_MEM:

> #define IORESOURCE_SYSTEM_RAM           (IORESOURCE_MEM|IORESOURCE_SYSRAM)

Did you want the patch to expand this #define, or did you just want to
ensure that IORESORUCE_MEM got in there somehow?