linux-kernel - Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable 'srf'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <fa71970ceec73faff082008820389a9ad1a8f5be.camel@vmware.com>
Date:   Wed, 16 Jan 2019 05:35:05 +0000
From:   Thomas Hellstrom <thellstrom@...are.com>
To:     "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        Linux-graphics-maintainer <Linux-graphics-maintainer@...are.com>,
        "syeh@...are.com" <syeh@...are.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable 'srf'

Yue,

Thanks,
Reviewed-by: Thomas Hellstrom <thellstrom@...are.com>

Will include in the next -next pull.
/Thomas


On Wed, 2019-01-16 at 01:55 +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/gpu/drm/vmwgfx/vmwgfx_surface.c: In function
> 'vmw_hw_surface_destroy':
> drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:335:22: warning:
>  variable 'srf' set but not used [-Wunused-but-set-variable]
> 
> It never used since commit 543831cfc976 ï¼^"drm/vmwgfx: Break out
> surface and
> context management to separate files")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> index 80a01cd..3b6976e 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> @@ -332,7 +332,6 @@ static void vmw_hw_surface_destroy(struct
> vmw_resource *res)
>  {
>  
>  	struct vmw_private *dev_priv = res->dev_priv;
> -	struct vmw_surface *srf;
>  	void *cmd;
>  
>  	if (res->func->destroy == vmw_gb_surface_destroy) {
> @@ -359,7 +358,6 @@ static void vmw_hw_surface_destroy(struct
> vmw_resource *res)
>  		 */
>  
>  		mutex_lock(&dev_priv->cmdbuf_mutex);
> -		srf = vmw_res_to_srf(res);
>  		dev_priv->used_memory_size -= res->backup_size;
>  		mutex_unlock(&dev_priv->cmdbuf_mutex);
>  	}
> 
> 
>