linux-kernel - Re: [PATCH 3/5] staging: erofs: decrease the shrink count in erofs_workgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190116104553.GE4482@kadam>
Date:   Wed, 16 Jan 2019 13:45:53 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Gao Xiang <gaoxiang25@...wei.com>
Cc:     Chao Yu <yuchao0@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-erofs@...ts.ozlabs.org,
        Chao Yu <chao@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        weidu.du@...wei.com, Fang Wei <fangwei1@...wei.com>,
        Miao Xie <miaoxie@...wei.com>
Subject: Re: [PATCH 3/5] staging: erofs: decrease the shrink count in
 erofs_workgroup_get

On Wed, Jan 16, 2019 at 04:59:54PM +0800, Gao Xiang wrote:
> It is more suitable to update in erofs_workgroup_get since
> it's actually the one matched with erofs_workgroup_put.
> 

This patch is fine.  No need to resend.

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

But for future reference, I found the commit message a bit confusing.
Ideally, I would understand basically what the commit does and why
without needing to read the diff.

I mostly just read the subject or the commit message, either or, instead
of reading both.  (This is not really true.)  My email client looks like
this.  (Also not true).

https://marc.info/?l=linux-driver-devel&m=154762932712086&w=2

While none of that was strictly true, it is a little bit true-ish...
So please, assume that some people will start reading the commit message
without reading the subject.

I sort of thought from reading the commit message that it was a bugfix
or a behavior change.  A better commit message would be:

staging: erofs: move shrink accounting inside the function

This patch moves the &erofs_global_shrink_cnt accounting from the caller
to erofs_workgroup_get().  It's cleaner and it matches erofs_workgroup_put()
better.  No behavior change.

regards,
dan carpenter