linux-kernel - Re: [PATCH] libertas: remove ifdef OLPC noise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zhs04mhr.fsf@codeaurora.org>
Date:   Wed, 16 Jan 2019 18:04:48 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     libertas-dev@...ts.infradead.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libertas: remove ifdef OLPC noise

Lubomir Rintel <lkundrak@...sk> writes:

> <asm/olpc.h> provides machine_is_olpc() stub for CONFIG_OLPC=n,
> compiler should just optimize the unneeded bits away.
>
> Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> ---
>  drivers/net/wireless/marvell/libertas/if_usb.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/wireless/marvell/libertas/if_usb.c
> index 220dcdee8d2b..7b61c599948e 100644
> --- a/drivers/net/wireless/marvell/libertas/if_usb.c
> +++ b/drivers/net/wireless/marvell/libertas/if_usb.c
> @@ -12,9 +12,7 @@
>  #include <linux/usb.h>
>  #include <linux/olpc-ec.h>
>  
> -#ifdef CONFIG_OLPC
>  #include <asm/olpc.h>
> -#endif

Using asm directory looked odd to me so I did some investigation:

$ find -name olpc.h
./arch/x86/include/asm/olpc.h

Did you build this on something else than x86? For example, will the
compiler find olpc.h when building for arm?

-- 
Kalle Valo