linux-kernel - Re: [PATCH 5/6] spi: ath79: Remove some useless includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Jan 2019 12:06:41 -0800
From:   Joe Perches <joe@...ches.com>
To:     Alban Bedel <albeu@...e.fr>, linux-kernel@...r.kernel.org
Cc:     Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org
Subject: Re: [PATCH 5/6] spi: ath79: Remove some useless includes

On Wed, 2019-01-16 at 19:55 +0100, Alban Bedel wrote:
> Several include are not needed, remove them to keep the list clean.
[]
> diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c
[]
> @@ -12,15 +12,12 @@
>   *
>   */
>  
> -#include <linux/kernel.h>

I think it's not a good idea to remove kernel.h
just because module.h indirectly #includes it via
moduleparam.h