linux-kernel - RE: [PATCH] scsi: ufs: revamp string descriptor reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN6PR04MB492505EFD15BB09BDC0A4D80FC830@SN6PR04MB4925.namprd04.prod.outlook.com>
Date:   Thu, 17 Jan 2019 08:14:54 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     "Winkler, Tomas" <tomas.winkler@...el.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Vinayak Holikatti <vinholikatti@...il.com>,
        "Hunter, Adrian" <adrian.hunter@...el.com>
CC:     Christoph Hellwig <hch@....de>,
        Vivek Gautam <vivek.gautam@...eaurora.org>,
        Subhash Jadavani <subhashj@...eaurora.org>,
        Alex Lemberg <Alex.Lemberg@....com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: ufs: revamp string descriptor reading

> 
> > > Hello Tomas,
> > >
> > > >
> > > > Define new a type: uc_string_id for easier string handling and less
> > > > casting. Reduce number or string copies in price of a dynamic
> > > > allocation.
> > > >
> > > > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> > > Tested-by: Avri Altman <avri.altman@....com>
> > >
> > > Just one nit - doesn't really matters.
> > >
> > > Cheers,
> > > Avri
> > >
> > > > ---
> > > >  drivers/scsi/ufs/ufs-sysfs.c |  20 ++---
> > > >  drivers/scsi/ufs/ufs.h       |   2 +-
> > > >  drivers/scsi/ufs/ufshcd.c    | 164 +++++++++++++++++++++--------------
> > > >  drivers/scsi/ufs/ufshcd.h    |   9 +-
> > > >  4 files changed, 115 insertions(+), 80 deletions(-)
> > >
> > >
> > > >
> > > >  	ufs_fixup_device_setup(hba, &card);
> > > > +	ufs_put_device_desc(&card);
> > > ufs_get_device_desc() and ufs_put_device_desc() actually serves the
> > > quirks setup.
> > > Make sense to call it from within so the logic is clear and in one place.
> > > Might also save ufs_put_device_desc().
> >
> > You are right from the current perspective , just I'd need it also for the
> RPMB
> > patches that should follow, then it will have bit larger span than the quirks.
> >
> 
> Is this okay, can we merge?
Looks good to me.

Thanks,
Avri

> Thanks
> Tomas