linux-kernel - Re: [PATCH] x86/traps: Have read_cr0() only once in the #NM handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190117121420.wsjyynxnznwkcew2@linutronix.de>
Date:   Thu, 17 Jan 2019 13:14:20 +0100
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Borislav Petkov <bp@...en8.de>
Cc:     X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...capital.net>
Subject: Re: [PATCH] x86/traps: Have read_cr0() only once in the #NM handler

On 2019-01-17 13:07:28 [+0100], Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> ... instead of twice in the code. In any case, CR0 ends up being read
> once anyway:
> 
> 1. The CONFIG_MATH_EMULATION case does so and exits.
> 2. The normal case does it once too.
> 
> However, read it on function entry instead to make the code even simpler
> to follow.

makes sense.

Acked-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Sebastian