linux-kernel - Re: Aw: [PATCH 2/2] drm/mediatek: Add Mediatek framebuffer device

Open Source and information security mailing list archives

Message-ID: <1547775975.4221.11.camel@mtksdaap41>
Date:   Fri, 18 Jan 2019 09:46:15 +0800
From:   CK Hu <ck.hu@...iatek.com>
To:     Frank Wunderlich <frank-w@...lic-files.de>
CC:     Philipp Zabel <p.zabel@...gutronix.de>,
        <srv_heupstream@...iatek.com>, David Airlie <airlied@...ux.ie>,
        <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        "\"Noralf Tr�nnes"" <noralf@...nnes.org>,
        <linux-mediatek@...ts.infradead.org>,
        Daniel Vetter <daniel@...ll.ch>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: Aw: [PATCH 2/2] drm/mediatek: Add Mediatek framebuffer device

Hi, Frank:

On Thu, 2019-01-17 at 15:14 +0100, Frank Wunderlich wrote:
> Hi,
> 
> this Patchset does not hang on Bananapi R2, but does not show anything on FB-Console...seems anything is missing
> 
> https://github.com/frank-w/BPI-R2-4.14/tree/4.20-fbdev
> 
> dmesg | grep 'fb\|framebuffer'
> [    0.000000] Linux version 4.20.0-rc7-bpi-r2-fbdev (frank@...nk-N56VZ) (gcc version 7.3.0 (Ubuntu/Linaro 7.3.0-27ubuntu1~18.04)) 9
> [    0.000000] cma: Reserved 64 MiB at 0xfb800000
> [    0.000000] Kernel command line: board=bpi-r2 console=earlyprintk console=tty1 fbcon=map:0 console=ttyS0,115200 root=/dev/mmcblk7
> [    5.733185] [drm:drm_fb_helper_generic_probe] surface width(1280), height(1024) and bpp(32)
> [    5.754452] [drm:drm_mode_addfb2] [FB:44]
> [    5.792878] mediatek-drm 14000000.dispsys: fb0: DRM emulated frame buffer device
> [    5.814067] [drm:drm_fb_helper_hotplug_event.part.11] 
> [    6.203083] mediatek-drm 14000000.dispsys: [drm:drm_client_dev_hotplug] fbdev: ret=0
> [   24.930347] mediatek-drm 14000000.dispsys: [drm:drm_client_dev_restore] fbdev: ret=0
> [   25.196872] mediatek-drm 14000000.dispsys: [drm:drm_client_dev_restore] fbdev: ret=0
> [   25.281184] [drm:drm_mode_addfb2] [FB:49]
> [   27.947962] [drm:drm_mode_addfb2] [FB:49]

The log does not show any information of error, but it close fbdev at
the time 24.930347.

I just test vmap() by writing white color into framebuffer after vmap()
and use user space program to control fbdev to show this framebuffer and
the panel shows white screen. So I believe that vmap() and fbdev works
fine, but I'm not sure what happen to fbcon. I would try to setup fbcon
to find out the bug. If you could try to debug parallelly, it would be
much help.

Regards,
CK

> 
> regards Frank
> 
> 
> > Gesendet: Mittwoch, 16. Januar 2019 um 02:39 Uhr
> > Von: "CK Hu" <ck.hu@...iatek.com>
> > An: "Philipp Zabel" <p.zabel@...gutronix.de>, "David Airlie" <airlied@...ux.ie>, "Daniel Vetter" <daniel@...ll.ch>, "Matthias Brugger" <matthias.bgg@...il.com>, "Noralf Tr�nnes" <noralf@...nnes.org>, "Frank Wunderlich" <frank-w@...lic-files.de>
> > Cc: dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org, srv_heupstream@...iatek.com, "CK Hu" <ck.hu@...iatek.com>
> > Betreff: [PATCH 2/2] drm/mediatek: Add Mediatek framebuffer device
> >
> > For Mediatek drm driver, use fbdev emulation to create a framebuffer
> > device.
> > 
> > Signed-off-by: CK Hu <ck.hu@...iatek.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > index 6ec4ca070382..5fcc0e294696 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > @@ -16,6 +16,7 @@
> >  #include <drm/drm_atomic.h>
> >  #include <drm/drm_atomic_helper.h>
> >  #include <drm/drm_crtc_helper.h>
> > +#include <drm/drm_fb_helper.h>
> >  #include <drm/drm_gem.h>
> >  #include <drm/drm_gem_cma_helper.h>
> >  #include <drm/drm_of.h>
> > @@ -378,6 +379,10 @@ static int mtk_drm_bind(struct device *dev)
> >  	if (ret < 0)
> >  		goto err_deinit;
> >  
> > +	ret = drm_fbdev_generic_setup(drm, 32);
> > +	if (ret)
> > +		DRM_ERROR("Failed to initialize fbdev: %d\n", ret);
> > +
> >  	return 0;
> >  
> >  err_deinit:
> > -- 
> > 2.18.1
> > 
> >
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives