linux-kernel - Re: [PATCH v4 9/9] hwmon (occ): Add sysfs attributes for additional OCC data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Jan 2019 12:47:08 +1100
From:   Joel Stanley <joel@....id.au>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Eddie James <eajames@...ux.vnet.ibm.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, linux-hwmon@...r.kernel.org,
        devicetree <devicetree@...r.kernel.org>,
        linux-doc@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Jean Delvare <jdelvare@...e.com>,
        Mark Rutland <mark.rutland@....com>,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        Rob Herring <robh+dt@...nel.org>,
        Kate Stewart <kstewart@...uxfoundation.org>
Subject: Re: [PATCH v4 9/9] hwmon (occ): Add sysfs attributes for additional
 OCC data

On Fri, 18 Jan 2019 at 11:44, Thomas Gleixner <tglx@...utronix.de> wrote:
>
> Eddie,
>
> On Wed, 11 Jul 2018, Eddie James wrote:
>
> > --- /dev/null
> > +++ b/drivers/hwmon/occ/sysfs.c
> > @@ -0,0 +1,188 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * OCC hwmon driver sysfs interface
> > + *
> > + * Copyright (C) IBM Corporation 2018
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
>
> The above license information is inconsistent.
>
> The SPDX license identifier says GPL v2 only, but the license notice says
> GPL v2 or later. This is just wrong.
>
> Please decide which one to use and please also remove the boiler plate
> text. It is redundant.
>
> See Documentation/process/license-rules.rst

Thanks Thomas.

Eddie, as IBM contributed code our preferred license is GPLv2+. Be
sure to include the copyright line in your header (I noticed some OCC
files are missing this, please audit all of your recent
contributions):

// SPDX-License-Identifier: GPL-2.0+
// Copyright IBM Corp 2019

Cheers,

Joel