linux-kernel - Re: [PATCH v2 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5349edd-015f-75da-c47d-90e931f99d43@suse.de>
Date:   Sat, 19 Jan 2019 12:30:14 +0100
From:   Andreas Färber <afaerber@...e.de>
To:     Martyn Welch <martyn.welch@...labora.com>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Fabio Estevam <fabio.estevam@....com>,
        devicetree@...r.kernel.org, Christian Hemp <c.hemp@...tec.de>,
        Stefan Riedmüller <s.riedmueller@...tec.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-arm-kernel@...ts.infradead.org,
        NXP Linux Team <linux-imx@....com>,
        Rob Herring <robh@...nel.org>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Thierry Reding <treding@...dia.com>,
        linux-kernel@...r.kernel.org, Kevin Hilman <khilman@...libre.com>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: Add vendor prefix for Catalyst
 Semiconductor

Hi Martyn,

Am 18.01.19 um 20:48 schrieb Martyn Welch:
> Add vendor prefix "catalyst" for Catalyst Semiconductor which is
> already in use but undocumented.
> 
> Signed-off-by: Martyn Welch <martyn.welch@...labora.com>
> Reviewed-by: Rob Herring <robh@...nel.org>
> ---
> 
> Changes in v2: None
> 
>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 389508584f48..d80b23b7771f 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -65,6 +65,7 @@ bticino Bticino International
>  calxeda	Calxeda
>  capella	Capella Microsystems, Inc
>  cascoda	Cascoda, Ltd.
> +catalyst	Catalyst Semiconductor, Inc

"Inc" surely is an abbreviation for "Incorporated", so can you please
follow the below examples of writing "Inc." with trailing dot?

>  cavium	Cavium, Inc.
>  cdns	Cadence Design Systems Inc.
>  cdtech	CDTech(H.K.) Electronics Limited

Otherwise looks good. Thanks for fixing the undocumented use.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)