linux-kernel - Re: [PATCH v4 4/4] hwrng: add OP-TEE based rng driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190121103026.GB15590@kroah.com>
Date:   Mon, 21 Jan 2019 11:30:26 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sumit Garg <sumit.garg@...aro.org>
Cc:     jens.wiklander@...aro.org, herbert@...dor.apana.org.au,
        linux-arm-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, mpm@...enic.com, robh+dt@...nel.org,
        mark.rutland@....com, arnd@...db.de, daniel.thompson@...aro.org,
        ard.biesheuvel@...aro.org, bhsharma@...hat.com,
        tee-dev@...ts.linaro.org
Subject: Re: [PATCH v4 4/4] hwrng: add OP-TEE based rng driver

On Mon, Jan 21, 2019 at 02:59:19PM +0530, Sumit Garg wrote:
> --- /dev/null
> +++ b/drivers/char/hw_random/optee-rng.c
> @@ -0,0 +1,272 @@
> +// SPDX-License-Identifier: GPL-2.0

Nice, but:

<snip>

> +MODULE_LICENSE("GPL");

This string means "GPL2+", you need "GPLv2" here instead.

Yeah, it's a pain, and everyone gets it wrong, we need to add a
checkpatch.pl rule for this to keep it from being added in new code.

thanks,

greg k-h